Don't use CMAKE_INSTALL_PREFIX in tokenizers-config.cmake #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Looks like we need to use a new PATH_VAR instead.
swolchok
force-pushed
the
more-install-fixes
branch
from
0c35fc5 to
9327e08
Compare
swolchok
changed the title
larryliu0820
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we need to use a new PATH_VAR instead -- tokenizers-config.cmake is evaluated in the context of the build doing find_package(tokenizers), so CMAKE_INSTALL_PREFIX is where that build would install things. Instead, we want to know where tokenizers was installed.